fix: don't call the retry prompt if a command has a default value #208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
when executing
Argument.process
,choice
is called to determine if the command has optional arguments or not. the problem being in the first parameter,this.prompt && this.prompt.optional
, determines if aoptional
value is set within a command's args object, however it doesn't check if a default value is set.so, if a command is ran with a default value, a retry prompt is still executed as the first parameter doesn't check if a default value is set for the argument.
example
if we have a command with args set as
and the command is run as
.greet
, a retry prompt is called even though the command has a default value set.solution
the solution is rather simple, just check if the command has a default value before checking if the
optional
property is set within the command's prompt.