Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Move to TF iterators #23

Merged
merged 7 commits into from
Feb 26, 2024
Merged

DRAFT: Move to TF iterators #23

merged 7 commits into from
Feb 26, 2024

Conversation

dirmeier
Copy link
Owner

@dirmeier dirmeier commented Feb 26, 2024

The TF iterator is significantly faster than our implementation.

Drawback: how to convert set of batches to iterator, e.g., as used by summary statistic methods).

@dirmeier dirmeier marked this pull request as draft February 26, 2024 12:55
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 71.71053% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 50.36%. Comparing base (f4f43d1) to head (f48f9bf).

Files Patch % Lines
sbijax/_src/snass.py 15.00% 17 Missing ⚠️
sbijax/_src/util/data_test.py 75.00% 15 Missing ⚠️
sbijax/_src/snasss.py 25.00% 6 Missing ⚠️
sbijax/_src/snr.py 0.00% 4 Missing ⚠️
sbijax/_src/util/data.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   50.04%   50.36%   +0.32%     
==========================================
  Files          27       29       +2     
  Lines        1247     1245       -2     
==========================================
+ Hits          624      627       +3     
+ Misses        623      618       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirmeier dirmeier marked this pull request as ready for review February 26, 2024 19:53
@dirmeier dirmeier merged commit db2a588 into main Feb 26, 2024
7 checks passed
@dirmeier dirmeier deleted the tf-data-iterator branch February 26, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant