Fixed dataset 'true' & 'false' conversions to boolean values in check() #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkgroenen
requested changes
Aug 5, 2022
src/viewportchecker.ts
Outdated
| * Turns strings 'true' or 'false' into booleans | ||
| */ | ||
| const getBooleanStringRepresentation = (val: string): boolean => | ||
| val !== "true" && val !== "false" ? false : val === "true" ? true : false; |
There was a problem hiding this comment.
This one is double and can be shortened into val === "true" ? true : false.
src/viewportchecker.ts
Outdated
Comment on lines
184
to
189
| const val = | ||
| typeof $obj.dataset[dataKey] !== undefined ? | ||
| ( | ||
| $obj.dataset[dataKey] === "true" || $obj.dataset[dataKey] === "false" ? | ||
| getBooleanStringRepresentation($obj.dataset[dataKey]!) : $obj.dataset[dataKey] | ||
| ) : undefined; |
There was a problem hiding this comment.
For this one some of the checks can be removed, since they're implicitly also being done by your true/false expression:
const val = ["true", "false"].includes($obj.dataset[dataKey])
? getBooleanStringRepresentation($obj.dataset[dataKey]!)
: $obj.dataset[dataKey];This will check if the value is true or false and if so pass it on to your coercion function. If not it will just pass along the original value (which could be undefined or any other value)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the data values inside html elements are strings (for example
data-vp-repeat="true"), boolean values won't work inside check() function since both"true"and"false"are both true statements inif (objOptions.invertBottomOffset){}. So I checked what was the value in$obj.dataset[dataKey]and if it was"true"or"false"I converted them to boolean values with the helper method I created.I also made the demo website take the full screen because its easier to work with.