Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arrow misalignment in M2A relation settings #22350

Merged
merged 3 commits into from May 2, 2024

Conversation

hanneskuettner
Copy link
Contributor

Scope

What's changed:

  • Use a few wrappers to push the fields up or down
  • Actually position the arrows with the fields they are pointing to / from to not rely on fixed positions
Before After few After many
Screenshot 2024-04-30 at 19 48 05 Screenshot 2024-04-30 at 19 40 43 Screenshot 2024-04-30 at 19 40 54

Potential Risks / Drawbacks

None

Review Notes / Questions

None


Fixes #22348

Copy link

changeset-bot bot commented Apr 30, 2024

🦋 Changeset detected

Latest commit: 9a2fa18

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@directus/app Patch
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny issue, nice fix 😄

@paescuj paescuj merged commit 24d77d0 into main May 2, 2024
4 checks passed
@paescuj paescuj deleted the fix-22348-m2a-align-many-items branch May 2, 2024 12:08
@github-actions github-actions bot added this to the Next Release milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[App] Many to any relationship arrow misalligned
2 participants