Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add public registration #22125

Merged
merged 76 commits into from May 7, 2024
Merged

Add public registration #22125

merged 76 commits into from May 7, 2024
+944 −30

Conversation

DanielBiegler
Copy link
Contributor

@DanielBiegler DanielBiegler commented Apr 8, 2024 •
edited

Scope

What's changed:

  • New UI so you can go to register
  • It adds a new user with a specified role
  • Fixed a UI bug on the login page
  • DB migration that adds fields to directus_settings
  • Hide register button depending on directus_settings
  • Email validation via customizable filter
  • Add mailing service to send out the verification code
  • Email template for the verification email
  • New per-ip-rate-limiter for registration, their env vars and docs
  • Remove RATE_LIMITER_GLOBAL_STORE both from code and docs since we dont use it. Lets stick to one store for all limiters.
Settings Email
image image
Register Route After Success
image image
  • Fixed UI inconsistency in login & reset-password
Before After
Screencast.from.2024-04-08.20-49-44.webm
Screencast.from.2024-04-08.20-57-14.webm

Potential Risks / Drawbacks

  • todo

Review Notes / Questions

  • Dont forget to run the migration 😉

Fixes #21981

@changeset-bot changeset-bot

This comment was marked as resolved.

Sign in to view
@DanielBiegler
fix notice on register route
de3b6c7
@DanielBiegler
WIP register form
7cb09e2
@DanielBiegler
WIP: registering ui and controller for testing
3ca7722
@DanielBiegler
fix lint ordering problem
d8f1e20
@DanielBiegler
wip: users service
5d0861e
@DanielBiegler
add migration, initial style for fields in settings
3c1099d
@DanielBiegler
redo how emails will be filtered
be9bdbe
@DanielBiegler
WIP add filter in the register handler
266d114
@DanielBiegler
conditionally render register link depending on settings
38bbd9b
@DanielBiegler
Merge remote-tracking branch 'origin/main' into fix-21981-public-regi…
c4a9575 
…stration
@DanielBiegler
WIP: add email validation
950a8ac
@DanielBiegler
wip add email sending
4e54498
@DanielBiegler
make clicking the email link work
130cc9c
@DanielBiegler
rm console log
2a3ef64
@DanielBiegler
update controller
d7167d4
@DanielBiegler
dont send emails for existing emails
f9ebb9e
@DanielBiegler
add translation
6c2e6e2
@DanielBiegler
only show register link when unauthenticated
c9c19f6
@DanielBiegler
add different redirects
9eee9ea
@DanielBiegler
only allow selecting non-admin roles
316bd7c
@DanielBiegler
redirect to users page
17e41e6
@DanielBiegler
update translation
afcf208
@DanielBiegler
move logic from controller to usersservice
2f7c628
@DanielBiegler
rm remnant of logic from controller
2e6f166
@DanielBiegler
add stall time to registration
c9291b1
paescuj
paescuj reviewed May 7, 2024
View reviewed changes
Copy link
Member

@paescuj paescuj left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • What terminology have we agreed on? In the Data Studio "User Registration" is used, while the API configs use "public_registration". This should be aligned before merging.
  • Docs are missing for the new Project Settings 1, not sure if we still want to maintain this page, though.

Footnotes

  1. https://docs.directus.io/user-guide/settings/project-settings.html ↩

api/src/middleware/rate-limiter-registration.ts Outdated Show resolved Hide resolved
api/src/controllers/users.ts Show resolved Hide resolved
api/src/services/mail/templates/user-registration.liquid Show resolved Hide resolved
api/src/services/server.ts Outdated Show resolved Hide resolved
app/src/lang/translations/en-US.yaml Show resolved Hide resolved
app/src/routes/register/register-form.vue Show resolved Hide resolved
app/src/routes/register/register-form.vue Show resolved Hide resolved
app/src/routes/register/register-form.vue Show resolved Hide resolved
app/src/routes/register/register.vue Show resolved Hide resolved
api/src/controllers/users.ts Show resolved Hide resolved
br41nslug
br41nslug approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@br41nslug br41nslug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@br41nslug br41nslug merged commit c893b9f into main May 7, 2024
5 checks passed
@br41nslug br41nslug deleted the fix-21981-public-registration branch May 7, 2024 21:20
@github-actions github-actions bot added this to the Next Release milestone May 7, 2024
@licitdev licitdev mentioned this pull request May 13, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanneskuettner hanneskuettner hanneskuettner left review comments

@paescuj paescuj paescuj left review comments

@licitdev licitdev licitdev left review comments

@br41nslug br41nslug br41nslug approved these changes

Assignees
No one assigned
Labels
🍰 Feature 🍰 Improvement 📁 Authentication
Projects
Software Roadmap
Status: ✅ Done
Milestone
v10.11.0
Development

Successfully merging this pull request may close these issues.

Implement Public User Registration
5 participants
@DanielBiegler @hanneskuettner @paescuj @br41nslug @licitdev