STYLE: Fix unused loop control variable warning #3228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix unused loop control variable warning: show how to specify multiple output filenames for a combined workflow, and provide them to the corresponding sub-workflows. Fixes: ``` doc/examples/combined_workflow_creation.py:68:22: B007 Loop control variable `out_file` not used within loop body ``` raised for example in: https://github.com/dipy/dipy/actions/runs/9131684633/job/25111443178#step:4:116
jhlegarreta
force-pushed
the
FixCombinedWorkflowExampleWarning
branch
from
b0cb12c
to
05de2b6
Compare
jhlegarreta
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3228 +/- ##
=======================================
Coverage 83.69% 83.69%
=======================================
Files 153 153
Lines 21375 21375
Branches 3458 3458
=======================================
Hits 17890 17890
Misses 2624 2624
Partials 861 861 |
|
Failures are unrelated. |
|
@skoudoro once this gets merged, the |
Yes, I know, but I think I saw something strange, I need a moment during the day to test it and generate the doc to be sure all is ok |
skoudoro
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unused loop control variable warning: show how to specify multiple output filenames for a combined workflow, and provide them to the corresponding sub-workflows.
Fixes:
raised for example in:
https://github.com/dipy/dipy/actions/runs/9131684633/job/25111443178#step:4:116