Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Parallel Tracking Framework #3089

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

gabknight
Copy link
Contributor

WIP

Re-implementation of dipy's tracking algorithms using cython prange function over all seeds. This allows for efficient and transparent use of multi-threading for tracking.

@skoudoro
Copy link
Member

skoudoro commented Feb 29, 2024

Great! Thank you for this.

It is nice to show that it exists. there still some work like:

  • docstring
  • unittest
  • adding more algorithms
  • simplify tracking parameter
  • deprecated the current interface
  • adding examples
  • add a page to explain the framework
  • show how to build your tractography with python or cython element
  • adding benchmarks

but it should not take too long. It will not be in the next release, but it will be in the release in June/July

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.70%. Comparing base (7b16a78) to head (e3b6e06).
Report is 11 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3089      +/-   ##
==========================================
- Coverage   83.75%   83.70%   -0.06%     
==========================================
  Files         153      153              
  Lines       21348    21364      +16     
  Branches     3446     3450       +4     
==========================================
+ Hits        17881    17882       +1     
- Misses       2611     2626      +15     
  Partials      856      856              
Files Coverage Δ
dipy/direction/peaks.py 84.90% <100.00%> (+0.07%) ⬆️
dipy/tracking/utils.py 92.11% <ø> (ø)

... and 3 files with indirect coverage changes

@skoudoro
Copy link
Member

skoudoro commented Mar 6, 2024

We also need to look at #1404 in this PR

@pep8speaks
Copy link

pep8speaks commented Mar 28, 2024

Hello @gabknight, Thank you for updating !

Line 15:1: E302 expected 2 blank lines, found 1
Line 15:81: E501 line too long (86 > 80 characters)
Line 29:1: E303 too many blank lines (3)
Line 33:81: E501 line too long (106 > 80 characters)
Line 35:19: E221 multiple spaces before operator
Line 35:81: E501 line too long (124 > 80 characters)
Line 37:23: E221 multiple spaces before operator
Line 42:81: E501 line too long (85 > 80 characters)
Line 44:81: E501 line too long (81 > 80 characters)
Line 46:23: E221 multiple spaces before operator
Line 46:81: E501 line too long (85 > 80 characters)
Line 50:27: E221 multiple spaces before operator
Line 66:81: E501 line too long (85 > 80 characters)
Line 69:81: E501 line too long (85 > 80 characters)
Line 70:81: E501 line too long (95 > 80 characters)
Line 72:81: E501 line too long (82 > 80 characters)
Line 85:81: E501 line too long (96 > 80 characters)

Comment last updated at 2024-05-16 19:54:24 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants