OPENPGP PLUGIN: Don't list expired/revoked GPG keys #1540
+35
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
@fiaxh This PR should close #91
I also changed the text when no key is selected from "No keys available. Generate one" to "No keys available. Generate one or check if your key isn't expired or revoked!"
I created a gpg key expiring few minutes after generation with a timestamp of 20240412T105500:
Here's a screenshot 2 minutes before expiring:
After closing dino and opening it back after the key expired:
But the input text box can still be used to send message, which are marked as failed but no reason is given.
I'll see if it's possible to block input on a revoked or expired key, and also have it checked without opening and closing dino.
Kind regards,
lili