Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny bare trait-objects #211

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Deny bare trait-objects #211

wants to merge 2 commits into from

Conversation

syberant
Copy link

@syberant syberant commented Jul 9, 2019

So I noticed there doesn't seem to be much work going on here at the moment and figured this might be a good time to make this PR since the likelyhood of massive quantities of merge conflicts is severely reduced. If this is not the right time then feel free to close this PR and schedule these changes for another time, all changes were made completely automated by running cargo fix after adding #![deny(bare_trait_objects)] to lib.rs.

dimforge/ncollide#297 provides a bit of background for the reasons why it's preferable to enforce dyn in front of every trait-object but in short it enhances their visibility by distinguishing them from structs.

@sebcrozet
Copy link
Member

sebcrozet commented Jul 9, 2019

Hi, thank you for this PR!

This is unfortunately not a good time as my comment on dimforge/ncollide#297 (comment) applies to nphysics too where massive work is also happening in the ccd branch. Sorry I did not mention nphysics in my aforementioned comment.

I'll keep this PR open for now though, just to remember that needs to be done at some point after the work on the ccd branch is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants