Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added deepProp, deepTheme, and deepPalette #59

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

jtmthf
Copy link
Collaborator

@jtmthf jtmthf commented Jan 30, 2019

Re-closes #55. Adds deepProp, deepTheme, and deepPalette.

Copy link
Owner

@diegohaz diegohaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again @jtmthf. I made a few suggestions (a yarn lint --fix may be needed after applying them).

Also, I was thinking about, instead of separate functions, a single function resolvePaletteProps that would return { key, tone, defaultValue } and then used as:

const { key, tone, defaultValue: finalDefaultValue } = resolvePaletteProps(...);

src/deepPalette.js Outdated Show resolved Hide resolved
src/deepPalette.js Outdated Show resolved Hide resolved
src/deepPalette.js Outdated Show resolved Hide resolved
src/deepPalette.js Outdated Show resolved Hide resolved
src/deepPalette.js Outdated Show resolved Hide resolved
src/utils.js Outdated Show resolved Hide resolved
src/utils.js Outdated Show resolved Hide resolved
src/utils.js Outdated Show resolved Hide resolved
src/utils.js Outdated Show resolved Hide resolved
src/utils.js Outdated Show resolved Hide resolved
@jtmthf
Copy link
Collaborator Author

jtmthf commented Apr 25, 2020

@diegohaz I recently had a use for this project and I forgot that I still had this PR open. I applied your suggestions and cleaned a few things up if you're still interested in this feature.

@exports
Copy link

exports commented May 25, 2020

I'm looking forward the new feature to solve my recent problems, will this be merged?

@iamgbayer
Copy link

is there something else needed to merge this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Needles should be recursively resolved
4 participants