Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include local support and add tests #43

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Include local support and add tests #43

merged 2 commits into from
Mar 8, 2024

Conversation

dieghernan
Copy link
Owner

Continue #42 and close #41

Thanks @alexwhitedatamine this PR mergs #42 in main with a few modifications:

  • I centralized the way the url is built with the new parameter nominatim_server in a single function prepare_api_url().
  • I also added tests and improve others, since a side effect of your PR is that now I can check errors on the api calls (by providing a fake nominatim server).
  • I added you as contributor in the DESCRIPTION, feel free to modify it.

Cheers

alexwhitedatamine and others added 2 commits March 8, 2024 14:48
* changed all references to nominatim api to be params

* fixed api url for search functions

* removed rogue print

* updated documentation to add nominatim_server

* fixed linting issues

* finalised linting changes
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.32%. Comparing base (9122576) to head (cfa8eed).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   99.29%   99.32%   +0.03%     
==========================================
  Files          10       10              
  Lines         426      447      +21     
==========================================
+ Hits          423      444      +21     
  Misses          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dieghernan dieghernan merged commit 9bc2d79 into main Mar 8, 2024
14 checks passed
@dieghernan dieghernan deleted the localsup branch March 8, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local Nominatim server not supported
2 participants