[Bugfix]: Not being able to equip two-handed items in a certain case (#5076) #7064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rgical#5076) Fix a bug that caused two-handed items not to able to be equipped if there was an item in the right hand, but not in the left one and also there wasn't enough space to place the right item TWO times. This was unintended, obviously, the right item should only be checked for once.
Tully-B
changed the title
|
DO NOT INCLUDE ISSUE LINKS IN COMMIT MESSAGES |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5076.
It seems that if there's an item only in the right hand, the function will also attempt to put something from the left hand into the inventory as well and if there's no space for it, the said issue will occur. I believe it actually tries to place the right hand item twice and if there's no place for two shields, the check will fail. This is not case if the shield is in your left hand, as it's handled separately I think.
This commit makes it so that no extra check performed when the left hand is empty in this case.