Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undeterministic Item Generation #7058

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kphoenix137
Copy link
Collaborator

@kphoenix137 kphoenix137 commented Apr 8, 2024

Gharbad and Zhar the Mad can keep changing their rolls in Single Player by doing anything that advances the random seed, and then talking to them. Exploitable behavior using save/load game. We set the monster seed, and then roll a new seed to avoid situations where killing the monsters drops a dupe of the item they previously gave you.

Copy link
Member

@StephenCWills StephenCWills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about DiscardRandomValues(10) instead of AdvanceRndSeed()?

@kphoenix137
Copy link
Collaborator Author

How about DiscardRandomValues(10) instead of AdvanceRndSeed()?

How do I mark this as resolved?

Copy link
Member

@StephenCWills StephenCWills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a feeling this is going to conflict with my RNG changes, but the code looks good.

@qndel qndel changed the title Fix Underministic Item Generation Fix undeterministic Item Generation Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants