Bugfix/Refactor: Min-Max Damage Range Calculations #7022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this made the demo run off the rails |
|
This likely addresses all the uses qndel identified in #6402 except the item.cpp changes, good to keep it focused for damage rolls. |
Should be good now? |
ephphatha
reviewed
Mar 15, 2024
ephphatha
reviewed
Mar 15, 2024
ephphatha
previously approved these changes
Mar 21, 2024
kphoenix137
force-pushed
the
refactor-functions-using-rnd-dmg
branch
from
e3488d5
to
b14455b
Compare
|
I think it would be nice to unify randomizing damage in the future - at the moment sometimes numbers are randomized before getting shifted, sometimes after, it's a mess - which means in some cases it's possible to get 1.5 dmg while in other places you'd get integers only - doesn't make much sense imo ;) |
ephphatha
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors damage calculations from the format:
damage = min + rnd(max - min + 1)to:
damage = randombetween(min, max)Also fixes a bug in some damage calculations, where max damage in the range is 63/64th lower than it should be.