Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite joining/leaving bosspack #6739

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rewrite joining/leaving bosspack #6739

wants to merge 1 commit into from

Conversation

qndel
Copy link
Member

@qndel qndel commented Oct 24, 2023 •
edited

Fixes #6661 and some other cases:

  • scavengers never rejoined the pack after feeding (because their relationship was getting set to LeaderRelation::None while feeding and GroupUnity reconnects only minions with LeaderRelation::Separated)
  • killing any minion while stone cursed basically blocked the whole pack, stone cursing any minion stopped the whole pack - now stone cursed monsters aren't in bosspack, initially I've added rejoining the pack on stone curse expiration but then we were back to the original issue - if a monster "destoned" far away from the pack, both pack and the monster would be stuck so I'm leaving GroupUnity as the only way to rejoin the pack - means monsters have to have line of sight of each other and distance is less than 4

@qndel qndel added the fix fix for a bug label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix fix for a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue Report]: Leader becomes immobile when stone cursing + killing ANY minion
1 participant
@qndel