Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partially revert menu tweaks to restore old look of diablo kill indicators #6727

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qndel
Copy link
Member

@qndel qndel commented Oct 19, 2023

Restores look from #5210
partial revert of 9e7d223

image
current look (getting reverted) as a reference

@AJenbo
Copy link
Member

AJenbo commented Oct 19, 2023

I feel the colors take to much focus, and since they are not radio buttons it feels unnecessary that it show indications when they are not active.

I would prefer if we keep it so that they switch between nothing and gray.

@Trihedraf
Copy link
Collaborator

I preferred having the red

@qndel
Copy link
Member Author

qndel commented Oct 19, 2023

I was confused when some characters had nothing and others had some grey dots, thought it was some bug, empty slots always being drawn indicate there's something you can do to fill them 🤷

Also most people seemed to prefer to have them outside of the portrait:
image

@AJenbo
Copy link
Member

AJenbo commented Oct 19, 2023

I'm allergic to colors. To me it really clashes with how things look :/

But how about red and nothing, that way it matches the small icons:
image
image
image
image

@qndel
Copy link
Member Author

qndel commented Oct 20, 2023

how about drawing nothing if character hasn't killed diablo but drawing remaining empty sockets after there's at least 1 colored gem?

@agris-codes
Copy link

agris-codes commented Oct 26, 2023

I have two suggestions.

  1. Location: the icons as proposed above, except for those outside the class portrait, are left-justified such that they crowd the faces in the portrait. I think moving the icons to the bottom-right of each portrait will look less cluttered, as heads are in the left segment of the frame and weapons tend to be in the top-right. I have no strong opinion on horizontal vs vertical alignment, although horizontal may look a bit less cluttered with the Sorcerer’s hand.

IMG_7622

  1. Icon appearance: I agree with @qndel re: drawing nothing when a player hasn’t defeated Diablo, although I share @AJenbo ’s concern that the outlines make them look like radio toggles. My suggestion is to use either the blood stone inventory graphic in small (16x16? 24x24?) dimensions, or a simple pentagram. The blood stone looks enough like the soul stone to be evocative, and the pentagram is self explanatory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants