Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Prevent negative Golem HP #6666

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix: Prevent negative Golem HP #6666

wants to merge 2 commits into from

Conversation

kphoenix137
Copy link
Collaborator

@kphoenix137 kphoenix137 commented Sep 28, 2023 •
edited

Fixes: #1521
Fixes: #1522

@StephenCWills
Copy link
Member

Probably, there is some relevant discussion in #1523.

StephenCWills
StephenCWills reviewed Sep 28, 2023
View reviewed changes
Source/monster.cpp Outdated Show resolved Hide resolved
@kphoenix137 @StephenCWills
Update Source/monster.cpp
b45542e 
Co-authored-by: Stephen C. Wills <[email protected]>
@FitzRoyX
Copy link

I think there was some question on whether the proper fix was to prevent the player's mana from going negative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenCWills StephenCWills StephenCWills left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Golem HP overflows when cast with negative mana Monsters don't target Golem
3 participants
@kphoenix137 @StephenCWills @FitzRoyX