Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift+Left Click Fail To Equip Two Handed Weapons If The Main Hand Is Empty #5076

Open
NiteKat opened this issue Jul 19, 2022 · 1 comment · May be fixed by #7064
Open

Shift+Left Click Fail To Equip Two Handed Weapons If The Main Hand Is Empty #5076

NiteKat opened this issue Jul 19, 2022 · 1 comment · May be fixed by #7064

Comments

@NiteKat
Copy link
Contributor

NiteKat commented Jul 19, 2022

Operating System

Windows x64

DevilutionX version

1.4.0 (latest release)

Describe

If you have a shield equipped in the hand slot on the right side of the screen and Shift + Left Click a bow, it will say you have no room and not swap the shield for the bow.

Shift + Left Click will work if you have a weapon and shield equipped, with a shield in the left hand on the screen, but fails in the right.

To Reproduce

  1. Find a bow and a shield.
  2. Equip shield into the hand visually on the right side of inventory.
  3. Shift + Left Click bow in inventory, hear message you have no room.

Expected Behavior

Shield and bow should be swapped (or bow equipped and shield unequipped)

Additional context

image
image
Both screen shots, should be able to Shift + Left Click the bow and equip it, but you cannot. In second screenshot, if the spiked club is also equipped, it will swap both weapon and shield off and equip the bow.
@ephphatha ephphatha changed the title Shift+Left Click Fail To Equip Bow In Certain Circumstance Shift+Left Click Fail To Equip Two Handed Weapons If The Main Hand Is Empty Jul 19, 2022
@ephphatha
Copy link
Contributor

Shift-clicking fails to equip any two-handed weapon with a one handed item in the off-hand, but only if the item in the off-hand was dropped into the off-hand slot from the inventory. If you swap the item from the main hand to the off-hand then shift-clicking works.

Tully-B added a commit to Tully-B/devilutionX that referenced this issue Apr 10, 2024
@Tully-B
Fix not being able to equip two-handed items in a certain case (diasu…
1461365 
…rgical#5076)

Fix a bug that caused two-handed items not to able to be equipped
if there was an item in the right hand, but not in the left one
and also there wasn't enough space to place the right item TWO times.
This was unintended, obviously, the right item should only be checked for once.
@Tully-B Tully-B linked a pull request Apr 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Bugfix]: Not being able to equip two-handed items in a certain case (#5076) Tully-B/devilutionX
2 participants
@ephphatha @NiteKat