Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ add OCO_EMOJI_POSITION_BEFORE_DESCRIPTION #288

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ThomasSanson
Copy link

Hello @di-sukharev,

I have submitted this pull request wherein I have made several amendments to your opencommit project.

  1. I have introduced a new configuration key OCO_EMOJI_POSITION_BEFORE_DESCRIPTION that allows users to customise the position of the emoji within the commit message. This provides users with greater flexibility in formatting their commit messages.

  2. I have updated the instructions within generateCommitMessageFromGitDiff.ts to reflect this new option.

  3. I have also updated the README.md file to include instructions on how to utilise the OCO_EMOJI_POSITION_BEFORE_DESCRIPTION configuration. This configuration allows users to determine where the GitMoji should be placed within the commit message.

  4. I have updated the assistant to accommodate the new OCO_EMOJI_POSITION_BEFORE_DESCRIPTION configuration. The assistant now generates commit messages based on the emoji position specified by the user.

  5. Lastly, I have updated the package version from 2.4.2 to 3.0.4 to reflect these new modifications and improvements.

I would like to emphasise that I have tested these modifications locally and everything appears to be functioning as expected.
The results are visible in the commit.

However, I would like to draw your attention to the fact that the documentation for contributing to the project is somewhat sparse. This could make access to contribution more challenging for new contributors. I believe it would be beneficial to enhance this aspect to facilitate community contribution.

Thank you for your time and consideration. I eagerly await your feedback on my pull request.

Close #219

…ION config key and implement its usage in prompts

The new configuration key OCO_EMOJI_POSITION_BEFORE_DESCRIPTION has been added to allow users to specify the position of the GitMoji in the commit message. This provides flexibility for users who may have different preferences for the placement of the GitMoji. The prompts have been updated to reflect this new configuration option and will now generate commit messages according to the user's preference.
Copy link

Stale pull request message

# Conflicts:
#	out/cli.cjs
#	out/github-action.cjs
#	package-lock.json
… commit messages

This update provides users with the ability to customize the placement of GitMoji in their commit messages. It includes examples and command line instructions for setting the GitMoji position either before the description or at the start of the commit message.
@ThomasSanson
Copy link
Author

@di-sukharev, may I kindly request that you assume responsibility for this pull request ?

Indeed, it appears that each time you approve another pull request, it leads to git conflicts on this one. To prevent such occurrences, it seems prudent for you to manage this task, thereby facilitating a more autonomous and direct resolution of the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Change Emoji Placement to Align with Tools and Standards
2 participants