Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support ALB Event response headers #1756

Merged
merged 2 commits into from
May 22, 2024

Conversation

corwinm
Copy link
Contributor

@corwinm corwinm commented Feb 6, 2024

Description

Motivation and Context

This PR adds support for ALB Event handlers to return headers.
This enables different "Content-Type" or "Set-Cookie" headers.

Fixes #1728

How Has This Been Tested?

Examples were added to manually test as well as integration tests added.

Screenshots (if appropriate):

@tristanl-slalom
Copy link

This looks great. This would help us with a solution based on ALB where we need to return redirect and cookies for our web app. Our work around for this is just to deploy the functions and test there, which is really sluggish for us!

@dnalborczyk
Copy link
Collaborator

thank you for the PR @corwinm ! could you run npm run prettier:fix over the changes?

I'll have a look over your PR in the next coming days.

@corwinm
Copy link
Contributor Author

corwinm commented Feb 14, 2024

Sorry @dnalborczyk, I meant to comment back. I ran prettier and updated the PR. Turns out I needed to configure my prettier plugin to run on yaml (or just use the script before committing).
Anything else I can do to help here?

@DorianMazur DorianMazur reopened this May 21, 2024
@DorianMazur DorianMazur merged commit 378ef71 into dherault:master May 22, 2024
9 checks passed
cnuss added a commit to scaffoldly/serverless-offline that referenced this pull request May 27, 2024
* master:
  fix: Support httpApi authorizer with different config and function names (dherault#1763)
  fix: Support ALB Event response headers (dherault#1756)
  v13.6.0
  fix: treat application/octet-stream as a binary encoding (dherault#1587)
  feat: add support for provided.al2023 (dherault#1788)
  v13.5.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ALB event doesn't reflect custom headers specified in handler.ts
4 participants