Handling the goto site steps which were previously skipped in the browser steps processing #2337
Conversation
…wser steps processing
|
|
||
| return valid_steps | ||
|
|
||
| return None | ||
|
|
||
| def iterate_browser_steps(self): | ||
| def iterate_browser_steps(self, url): |
There was a problem hiding this comment.
seems confusing and vague why this has url here
can you rename it to something like start_url ? or? im confused
| # If the operation is Goto site, change it to Goto URL and use the url as the optional value | ||
| if step['operation'] == 'Goto site': | ||
| step['operation'] = 'Goto URL' | ||
| optional_value = url |
There was a problem hiding this comment.
the function has url but its only used here? seems weird
| @@ -172,7 +172,7 @@ def run(self, | |||
|
|
|||
| # Run Browser Steps here | |||
| if self.browser_steps_get_valid_steps(): | |||
| self.iterate_browser_steps() | |||
| self.iterate_browser_steps(url) | |||
There was a problem hiding this comment.
try to use start_url = url or something
|
this comment is wrong, the first step is actually just empty |
|
It looks like you pushed a related commit, do I need to do anything on top of this? |
Nope all good, i ended up going it my own way because there was quite a few other changes/improvements , thanks for the inspiration! |
|
Thanks for taking care of it! ❤️ |
|
@manojVivek any chance you can pull and test the |
|
@dgtlmoon Tested and works great for me. 👏🏼 |
Fixes #2330