Cleaner: improved matchMask() #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janpecha
force-pushed
the
pr/ignore-masks
branch
6 times, most recently
from
c3cfe83
to
9be5fbd
Compare
janpecha
force-pushed
the
pr/ignore-masks
branch
from
9be5fbd
to
4e191b1
Compare
|
@dg What do you think about this? |
janpecha
force-pushed
the
pr/ignore-masks
branch
from
4e191b1
to
fbd4181
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
f3503a1
to
ac989d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaner currently supports
$ignoreMasksonly for files & directories from root of package directory. This PR improvesmatchMaskmethod and adds support for more complex masks. SeeCleaner.clean.phptfor example.Features:
autoloadkey incomposer.json, etc.)(Methods
collectPaths&matchMaskare taken fromftp-deployment,collectPathsis little modified)PR partially solves issue #13.