[Proof of Concept] MacOS Platform Layer #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jceipek
commented
Aug 15, 2021
Comment on lines
+573
to
+592
| if (clipboardData != nil) { | ||
| NSUInteger byteCount = [clipboardData lengthOfBytesUsingEncoding:NSUTF16StringEncoding]; | ||
| uint16_t* chars = (uint16_t*)malloc(byteCount); | ||
| if (chars) { | ||
| [clipboardData | ||
| getBytes:chars | ||
| maxLength:byteCount | ||
| usedLength:NULL | ||
| encoding:NSUTF16StringEncoding | ||
| options:0 | ||
| range:NSMakeRange(0, [clipboardData length]) | ||
| remainingRange:NULL]; | ||
| uint16_t* ptr = chars; | ||
| while (byteCount) { | ||
| gClip.reqData.push_back(*ptr++); | ||
| byteCount -= 2; // Since we're going 2 bytes at a time | ||
| } | ||
| free(chars); | ||
| } | ||
| } |
There was a problem hiding this comment.
I suspect there's a much easier way to do this, but I wasn't sure how.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rough pass at a MacOS platform layer for the Palanteer viewer application (note that I have not touched the instrumentation or scripting layer yet, and I haven't tested the networked recording, just loading trace files).
@dfeneyrou Huge props for making a really great profiling tool and writing it in such a way that porting to a new platform is feasible in a tractable amount of time. Please let me know if having a MacOS platform layer in the codebase is something you'd be interested in. I don't mind either way; this is mostly a learning project for me.
This is not really in a mergeable state yet, but I wanted to open it up for feedback and discussion on the approach. I've never written a shippable platform layer before and don't have a lot of experience with native MacOS APIs.
From a usability perspective, the two biggest outstanding problems are
Also: