Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare secrets just on not public clients
Overview
Removed client.Secret verification for public clients, maintaining the same behavior for private clients.
This PR addresses a specific need in our custom connector. Our custom connector relies on the secret as an authentication header. In the case of public clients, this header is also necessary for proper authentication. With this small change, the connector now functions seamlessly for both public and private clients. It's worth noting that this adjustment doesn't appear to impact code coverage or the expected behavior of the system.
Special notes for your reviewer