Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node-fetch dependency for unfetch TS definition file #98

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

1999
Copy link

@1999 1999 commented Oct 14, 2018

After a chat in #96 I decided to remove the node-fetch imports from unfetch definition file as now it produces TS compiler errors.

isomorphic-unfetch definion stayed untouched.

@AnselmMarie
Copy link

Is there an update on this PR?

@developit
Copy link
Owner

@1999 I'm so sorry for never responding to your PR. If possible, do you think you could take a look at #117 and tell me if that would work with your changes here?

@developit developit added needs-more-info information is needed to move forward help wanted labels Feb 18, 2020
@1999
Copy link
Author

1999 commented Feb 25, 2020

Yep, these changes look not related. Should be fine.

@developit
Copy link
Owner

I still need to check if this is correct. We landed #117 but I don't have a TypeScript project to test things out in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted needs-more-info information is needed to move forward typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants