Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check size for the universal image #979

Merged
merged 1 commit into from
Mar 11, 2024
Merged

check size for the universal image #979

merged 1 commit into from
Mar 11, 2024

Conversation

prathameshzarkar9
Copy link
Contributor

@prathameshzarkar9 prathameshzarkar9 commented Feb 29, 2024 •
edited
Loading

Dev container name:

  • universal
    Description:
    This PR is implementing the following functionality:
  • Github action checks the size of the universal container is exceeding the fixed threshold i.e. 14 GB or not and displays the report with the result success if it is below the threshold and fail if it is beyond the threshold.
    Changelog:
  • Updated test.sh
    • if Image is universal then call check_image_size function with two paramteres image and threshold.
  • Created check-image-size.sh
  • This file used to check the image size with the threshold and displays the output pass or fail

Checklist:

  • Checked that the container has been created and tried to run the github action for the image universal
  • Successfully checked the size of universal image and displayed report failed as the size exceeded the threshold

@prathameshzarkar9
Copy link
Contributor Author

prathameshzarkar9 commented Feb 29, 2024 •
edited
Loading

@prathameshzarkar9 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

samruddhikhandale
samruddhikhandale requested changes Mar 4, 2024
View reviewed changes
src/test-universal/.devcontainer.json Outdated Show resolved Hide resolved
src/test-universal/test-project/test.sh Outdated Show resolved Hide resolved
.github/actions/smoke-test/test.sh Outdated Show resolved Hide resolved
.github/actions/smoke-test/test.sh Outdated Show resolved Hide resolved
src/test-universal/check-size.sh Outdated Show resolved Hide resolved
@samruddhikhandale samruddhikhandale marked this pull request as ready for review March 4, 2024 22:59
@samruddhikhandale samruddhikhandale requested a review from a team as a code owner March 4, 2024 22:59
@prathameshzarkar9 prathameshzarkar9 force-pushed the check-image-size branch 2 times, most recently from 86a418e to 1fccf94 Compare March 7, 2024 21:46
samruddhikhandale
samruddhikhandale requested changes Mar 7, 2024
View reviewed changes
.github/actions/smoke-test/action.yaml Outdated Show resolved Hide resolved
.github/actions/smoke-test/action.yaml Show resolved Hide resolved
.github/actions/smoke-test/check-image-size.sh Outdated Show resolved Hide resolved
@prathameshzarkar9 prathameshzarkar9 force-pushed the check-image-size branch 4 times, most recently from c36369b to f6c5297 Compare March 8, 2024 06:47
prathameshzarkar9
prathameshzarkar9 commented Mar 8, 2024
View reviewed changes
Copy link
Contributor Author

@prathameshzarkar9 prathameshzarkar9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samruddhikhandale ,
requested changes incorporated. Kindly review the same

samruddhikhandale
samruddhikhandale requested changes Mar 8, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful PR, left some minor comments.

.github/actions/smoke-test/action.yaml Outdated Show resolved Hide resolved
.github/actions/smoke-test/check-image-size.sh Outdated Show resolved Hide resolved
.github/actions/smoke-test/check-image-size.sh Outdated Show resolved Hide resolved
.github/actions/smoke-test/check-image-size.sh Outdated Show resolved Hide resolved
.github/actions/smoke-test/check-image-size.sh Outdated Show resolved Hide resolved
@prathameshzarkar9 prathameshzarkar9 force-pushed the check-image-size branch 2 times, most recently from 8b3c659 to 4d038bf Compare March 11, 2024 05:51
samruddhikhandale
samruddhikhandale approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you so much! ⚡

@samruddhikhandale samruddhikhandale merged commit 92bed91 into devcontainers:main Mar 11, 2024
19 checks passed
@Botneyboy Botneyboy mentioned this pull request Jun 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prathameshzarkar9 @samruddhikhandale