Adds a helper script for "devcontainer upgrades" #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eljog
reviewed
Feb 8, 2024
| echo "-----------------------------------------------" | ||
| echo "Upgrading image $IMAGE_NAME" | ||
| echo "-----------------------------------------------" | ||
| devcontainer upgrade --workspace-folder "${workspaceFolder}/${IMAGE_NAME}/" |
There was a problem hiding this comment.
Prepare release script is already doing this
images/build/prepare-release.sh
Lines 45 to 52 in 3a72434
There was a problem hiding this comment.
But doesn’t that one also updates the versions in manifests?
Whenever I create a PR with some changes, I prefer to run upgrade command. Also, so that the dev tags which are scheduled on Monday could test with latest Features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I usually run
devcontainer upgradecommand when I make any changes to an image(s). This script helps to fasten the process.