Skip to content

Commit

Permalink
[miniconda] Remove the USER instruction to fix issue with `minicond…
Browse files Browse the repository at this point in the history
…a` template (#563)

* [miniconda] Remove `USER` instruction

- Remove `USER` instruction to make sure that all subsequent commands running form the root user

* [miniconda] Backport conda-forge checks
  • Loading branch information
alexander-smolyakov committed May 12, 2023
1 parent 98b5b1d commit 8fb5d26
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/miniconda/.devcontainer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ COPY environment.yml* noop.txt /tmp/conda-tmp/
RUN if [ -f "/tmp/conda-tmp/environment.yml" ]; then umask 0002 && /opt/conda/bin/conda env update -n base -f /tmp/conda-tmp/environment.yml; fi \
&& rm -rf /tmp/conda-tmp

USER vscode

# Temporary: Upgrade python packages due to mentioned CVEs
# They are installed by the base image (continuumio/miniconda3) which does not have the patch.
RUN python3 -m conda update -y \
Expand Down
2 changes: 2 additions & 0 deletions src/miniconda/test-project/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ cryptography_version=$(python -c "import cryptography; print(cryptography.__vers
check-version-ge "cryptography-requirement" "${cryptography_version}" "38.0.3"

check "conda-update-conda" bash -c "conda update -y conda"
check "conda-install" bash -c "conda install -c conda-forge --yes tensorflow"
check "conda-install" bash -c "conda install -c conda-forge --yes pytorch"

setuptools_version=$(python -c "import setuptools; print(setuptools.__version__)")
check-version-ge "setuptools-requirement" "${setuptools_version}" "65.5.1"
Expand Down

0 comments on commit 8fb5d26

Please sign in to comment.