Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix blurring of menu #609

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix blurring of menu #609

wants to merge 2 commits into from

Conversation

719media
Copy link

if you click and hold (without releasing mouse), the dropdown will still blur/hide. This is because the order of events goes

mousedown -> blur -> mouseup -> click

So basically you must click "quickly" or lose the menu

if you click and hold (without releasing mouse), the dropdown will still blur/hide. This is because the order of events goes

mousedown -> blur -> mouseup -> click

So basically you must click "quickly" or lose the menu
@tkirda
Copy link
Member

tkirda commented Apr 20, 2017

What was wrong before? Now if you don't release it quickly it just hides suggestions and does not select anything.

@alpha-and-omega
Copy link

Yep, again and again and this fix still not merged for almost a year @tkirda.
#685

@719media the problem with your fix is, that if you start clicking on results and then move mouse out of the results div, and release button, then autocomplete becomes broken (focus lost and nothing can hide results).

So after 2 hours of efforts I came to this solution:
https://gist.github.com/alpha-and-omega/10f4644abed5abb393b285e92baa4015
This just prevents losing focus by mousedown event and everything else works perfectly. My patch probably makes it posible to remove that idiotic delay in onBlur handler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants