Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bumpenvs for AMIs #9380

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

chore: bumpenvs for AMIs #9380

wants to merge 19 commits into from

Conversation

MikhailKardash
Copy link
Contributor

@MikhailKardash MikhailKardash commented May 15, 2024

Ticket

MD-410

Description

Update our AMIs and GKE images to have ngc-pytorch-dev images pre-downloaded
Undo a revert to our docs for image availability tables
Remove --cpu --cuda launcher flags for our slurm CI workloads (launcher scripts will need to be fixed in a follow-up PR)

Test Plan

CI passes

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.83%. Comparing base (0c42ced) to head (0c625c6).
Report is 44 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9380       +/-   ##
===========================================
- Coverage   46.01%   41.83%    -4.19%     
===========================================
  Files        1228      515      -713     
  Lines      155915    50570   -105345     
  Branches     2440        0     -2440     
===========================================
- Hits        71751    21158    -50593     
+ Misses      83973    29412    -54561     
+ Partials      191        0      -191     
Flag Coverage Δ
harness ?
web ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/config/provconfig/aws_config.go 11.20% <ø> (ø)
master/internal/config/provconfig/gcp_config.go 26.76% <100.00%> (ø)

... and 714 files with indirect coverage changes

@determined-ci determined-ci requested a review from a team May 15, 2024 23:59
@determined-ci determined-ci added the documentation Improvements or additions to documentation label May 15, 2024
Copy link

netlify bot commented May 15, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit efce6de
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6658aa8cff90370008b70c26

Copy link
Contributor

@hamidzr hamidzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I approved some of the long-running tests to run, are there any other tests that only run on main and not these feature branches that we care about to check? If so we might need to disable those protection to test that they pass

Copy link
Member

@tara-det-ai tara-det-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@determined-ci determined-ci requested a review from a team May 22, 2024 16:23
Copy link
Member

@tara-det-ai tara-det-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants