-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bumpenvs for AMIs #9380
base: main
Are you sure you want to change the base?
chore: bumpenvs for AMIs #9380
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9380 +/- ##
===========================================
- Coverage 46.01% 41.83% -4.19%
===========================================
Files 1228 515 -713
Lines 155915 50570 -105345
Branches 2440 0 -2440
===========================================
- Hits 71751 21158 -50593
+ Misses 83973 29412 -54561
+ Partials 191 0 -191
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Deploy Preview for determined-ui canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! I approved some of the long-running tests to run, are there any other tests that only run on main and not these feature branches that we care about to check? If so we might need to disable those protection to test that they pass
8a57bf2
to
34ac448
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ticket
MD-410
Description
Update our AMIs and GKE images to have ngc-pytorch-dev images pre-downloaded
Undo a revert to our docs for image availability tables
Remove
--cpu --cuda
launcher flags for our slurm CI workloads (launcher scripts will need to be fixed in a follow-up PR)Test Plan
CI passes
Checklist
docs/release-notes/
.See Release Note for details.