Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: print an error log when JSON-serializing fails #9365

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

azhou-determined
Copy link
Contributor

@azhou-determined azhou-determined commented May 14, 2024

Ticket

Description

Print an error log containing the object that failed to JSON-serialize. This method is used internally in enough places that an error log of the object should help debugging.

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Copy link

netlify bot commented May 14, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 508d4bf
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6643a6f4b1e5700007297fec

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 45.30%. Comparing base (4f180db) to head (508d4bf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9365      +/-   ##
==========================================
+ Coverage   45.28%   45.30%   +0.01%     
==========================================
  Files        1227     1227              
  Lines      154048   154053       +5     
  Branches     2404     2404              
==========================================
+ Hits        69766    69795      +29     
+ Misses      84090    84066      -24     
  Partials      192      192              
Flag Coverage Δ
backend 41.80% <ø> (+0.05%) ⬆️
harness 64.07% <50.00%> (-0.01%) ⬇️
web 36.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
harness/determined/util.py 73.17% <50.00%> (-0.59%) ⬇️

... and 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant