Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: helm install checks password complexity [DET-10293] #9360

Merged
merged 1 commit into from
May 21, 2024

Conversation

jesse-amano-hpe
Copy link
Contributor

@jesse-amano-hpe jesse-amano-hpe commented May 13, 2024

Ticket

DET-10293

Description

BREAKING CHANGE: helm: initial user passwords must satisfy some basic complexity requirements:

  • Passwords must be at least 8 characters long.
  • Passwords must contain at least one upper-case letter.
  • Passwords must contain at least one lower-case letter.
  • Passwords must contain at least one number.

Test Plan

Most likely not needed, this is mostly static helm templating.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label May 13, 2024
@determined-ci determined-ci added the documentation Improvements or additions to documentation label May 13, 2024
@determined-ci determined-ci requested a review from a team May 13, 2024 21:51
Copy link

netlify bot commented May 13, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 4d6a361
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66428f43aeeae70008c617e8
😎 Deploy Preview https://deploy-preview-9360--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.16%. Comparing base (0941fc4) to head (4d6a361).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9360      +/-   ##
==========================================
+ Coverage   45.14%   45.16%   +0.01%     
==========================================
  Files        1230     1230              
  Lines      154472   154472              
  Branches     2404     2404              
==========================================
+ Hits        69737    69766      +29     
+ Misses      84540    84511      -29     
  Partials      195      195              
Flag Coverage Δ
backend 41.80% <ø> (+0.05%) ⬆️
harness 64.07% <ø> (ø)
web 36.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@jesse-amano-hpe jesse-amano-hpe force-pushed the jta/DET-10293/helm-password-complexity branch from d012a9d to 4d6a361 Compare May 13, 2024 22:08
@determined-ci determined-ci removed the documentation Improvements or additions to documentation label May 13, 2024
@jesse-amano-hpe jesse-amano-hpe requested review from a team and salonig23 and removed request for a team May 13, 2024 22:08
Copy link
Member

@tara-det-ai tara-det-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesse-amano-hpe jesse-amano-hpe merged commit c3b3ae6 into main May 21, 2024
85 of 98 checks passed
@jesse-amano-hpe jesse-amano-hpe deleted the jta/DET-10293/helm-password-complexity branch May 21, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants