Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disableable rbac audit logging #9343

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

maxrussell
Copy link
Contributor

@maxrussell maxrussell commented May 9, 2024

Ticket

Description

I got annoyed with how noisy audit logging was, so I added a config for disabling it. Existing configs should work as they did previously, because leaving this unset (or setting it to false) keeps audit logging.

Additionally, I left a commented-out RBAC config in tools/devcluster.yaml so people can quickly toggle RBAC during development.

Test Plan

Audit logging should still happen unless it's explicitly disbled in config.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@maxrussell maxrussell requested review from a team and jesse-amano-hpe and removed request for a team May 9, 2024 01:36
@maxrussell maxrussell requested a review from a team as a code owner May 9, 2024 01:36
@cla-bot cla-bot bot added the cla-signed label May 9, 2024
Copy link

netlify bot commented May 9, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 4d6ea34
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/664b9bf9b9593400081176b6
😎 Deploy Preview https://deploy-preview-9343--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@maxrussell
Copy link
Contributor Author

Heads up: I'll be OOO until Monday May 13, so no rush on reviewing this.

Copy link
Contributor

@jesse-amano-hpe jesse-amano-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't rush on reviewing this, but then I almost forgot to come back to it -- apologies! Looks great though :)

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.53%. Comparing base (893f7f5) to head (4d6ea34).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9343      +/-   ##
==========================================
- Coverage   46.08%   39.53%   -6.56%     
==========================================
  Files        1228     1053     -175     
  Lines      155915   143071   -12844     
  Branches     2440     2439       -1     
==========================================
- Hits        71853    56558   -15295     
- Misses      83871    86322    +2451     
  Partials      191      191              
Flag Coverage Δ
harness 37.93% <ø> (-26.14%) ⬇️
web 38.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
agent/cmd/determined-agent/main.go 0.00% <ø> (ø)
agent/internal/options/options.go 27.77% <ø> (-1.32%) ⬇️
master/cmd/determined-master/main.go 0.00% <ø> (ø)
master/internal/config/authz_config.go 57.14% <ø> (ø)
master/internal/config/config.go 70.54% <ø> (-0.11%) ⬇️
master/internal/rbac/audit/audit.go 30.76% <ø> (ø)
master/pkg/logger/config.go 0.00% <ø> (ø)

... and 276 files with indirect coverage changes

@maxrussell maxrussell force-pushed the max/configure-audit-logging branch from b6d4a1c to 4d6ea34 Compare May 20, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants