Remove getLineAndColumnInPsiFile function #7261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked, see #7260 (comment) |
3flex
force-pushed
the
drop-getLineAndColumnInPsiFile
branch
from
3ce73b3
to
7781d65
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...yle/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/MultilineRawStringIndentation.kt
Fixed
Show fixed
Hide fixed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7261 +/- ##
============================================
+ Coverage 84.75% 84.77% +0.01%
+ Complexity 3992 3990 -2
============================================
Files 578 578
Lines 12027 12023 -4
Branches 2485 2478 -7
============================================
- Hits 10193 10192 -1
Misses 606 606
+ Partials 1228 1225 -3 ☔ View full report in Codecov by Sentry. |
This was introduced to work around issues with mutated PSI. This is no longer an issue since detekt#7206. Because the formatting rule set operates on a copy of the PsiFile and not the original PsiFile the original PsiFile will never be modified, so the protection offered by this function is not needed.
…ions There is no longer any reason to forbid usage of this function.
3flex
force-pushed
the
drop-getLineAndColumnInPsiFile
branch
from
6ad6ae7
to
766759d
Compare
BraisGabin
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced to work around issues with mutated PSI. This is no longer an issue since #7206. Because the formatting rule set operates on a copy of the PsiFile and not the original PsiFile the original PsiFile will never be modified, so the protection offered by this function is not needed.
This also masks some issues with rule implementations due to use of
runCatching- MaxLineLength was previously raisingIndexOutOfBoundExceptionwhenDiagnosticUtils.getLineAndColumnInPsiFilewas called, but it was caught byrunCatchingand the exception was hidden. Avoiding that behaviour will avoid masking those issues in future.