New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove detekt-psi-utils usage from detekt-api #7260
Conversation
9bf2820
to
4ec6ce3
Compare
Who should add |
It's already an implementation dependency of detekt-core, so it's on the runtime classpath: detekt/detekt-core/build.gradle.kts Line 12 in 38651f8
|
Oh, I thought that ci was failing exactly for that issue 🤐 |
If only it were that simple... it's failing because this function was catching an IndexOutOfBoundsException due to errors in the implementation of MaxLineLength:
The above code was catching the exception, and I didn't copy that exactly to the new location because it shouldn't be needed anymore. The MaxLineLength implementation should be fixed, but it looks like it needs changes to Location and/or Entity... until that's been corrected I'd call this and #7261 blocked. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7260 +/- ##
=========================================
Coverage 84.77% 84.77%
Complexity 3990 3990
=========================================
Files 578 578
Lines 12023 12027 +4
Branches 2478 2478
=========================================
+ Hits 10192 10196 +4
Misses 606 606
Partials 1225 1225 ☔ View full report in Codecov by Sentry. |
Closes #7140