Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the "Failed prop type" warning generated by prop-types' checkProp… #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

janis-github
Copy link

…Types

raw warning:
Failed prop type: LoadingOverlayWrapper: prop type 'styles.content' is invalid; it must be a function, usually from the 'prop-types' package, but received 'undefined'

fixes the issue: #56

…Types

Warning:
Failed prop type: LoadingOverlayWrapper: prop type 'styles.content' is invalid; it must be a function, usually from the 'prop-types' package, but received 'undefined'
@albeiroespitia
Copy link

+1

2 similar comments
@ArekMiszcz
Copy link

+1

@dalmau
Copy link

dalmau commented Feb 11, 2022

+1

@singleseeker
Copy link

Good job , plz merge this pr, @derrickpelletier

@bordernone
Copy link

please merge this.

@rcapulong
Copy link

+1 thanks!

@alexnatea
Copy link

I would be very grateful if you merge this resolved issue. Thank you guys!

@johnnyaug
Copy link

Thanks!

@janis-github
Copy link
Author

Obviously this repo is dead...
Here is a simple one-liner workaround:

import LoadingOverlay from "react-loading-overlay"
LoadingOverlay.propTypes = undefined

@Earthwormzim
Copy link

Package "@ronchalant/react-loading-overlay" doesn't appear to have this issue.

@njaniintel
Copy link

Please merge this

@FreelanceDev217
Copy link

Seriously, this repo is dead. move to https://github.com/paypal/react-paypal-js.

Copy link

@thirumalesh-ht thirumalesh-ht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamcarrollsimfy
Copy link

Please merge waiting on this 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet