Enable RSpec/EmptyExampleGroup #9731
Conversation
github-actions
bot
added
L: php:composer
|
Do we want to keep these tests or are we happy with deleting them? |
|
@robaiken could you dig out why they were disabled? As it stands, I'd rather delete them then keep them commented out, but if it's easy to fix them and make them reliable/fast, that seems better? |
| @@ -691,31 +691,6 @@ | |||
| end | |||
| end | |||
|
|
|||
| context "when there are patches (composer v2)" do | |||
There was a problem hiding this comment.
patch data isn't going to be re-applied to composer.lock
|
@jurre I couldn't find the context about why the NuGet tests were skipped. Both tests seemed to have issues related to VCR |
| # to match_array(%w(NuGet.Config packages.config)) | ||
| # end | ||
| it "fetches the packages.config" do | ||
| skip "This test was commented out and does not work at the moment" |
There was a problem hiding this comment.
Do we expect this will realistically ever be fixed?
| # expect(subject[:version]).to eq(version_class.new("6.5.0")) | ||
| # end | ||
| it "returns the expected version" do | ||
| skip "This test was commented out and does not work at the moment" |
There was a problem hiding this comment.
Same here, is there are plan to address this, or will this realistically just remain skipped?
|
@jurre I think it's up to the Azure team if they want to keep the tests or not. I have sent them a message, so they are aware of the skipped tests. |
https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecemptyexamplegroup