Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: Fixes issue when Dependabot generates a PR commit message that is longer than 65536 chars. #9728

Conversation

sachin-sandhu
Copy link
Contributor

@sachin-sandhu sachin-sandhu commented May 14, 2024

#8972 - Fixes issue when Dependabot generates a PR commit message that is longer than 65536 chars. Dependabot appends supplement information to PR commit message (dependnabot signature and message truncate confirmation information). In upper limit edge cases, this results in hitting max limit of 65536 characters. This causes dependabot to raise PR request with error 'Enabling auto-merge failed.
Commit message is too long'. A buffer of 1k (1024) characters is a safe limit that provides enough space to
provide supplement information without hitting the max ceiling limit. The message is trimmed at length 64512 (65536 - 1024) which leaves 1024 chars as a buffer to add additional information in Git PR commit message.

#8972 - Fixes issue when Dependabot generates a PR commit message that is longer than 65536 chars.
@sachin-sandhu sachin-sandhu requested a review from a team as a code owner May 14, 2024 12:26
@sachin-sandhu sachin-sandhu linked an issue May 14, 2024 that may be closed by this pull request
1 task
@robaiken
Copy link
Contributor

@sachin-sandhu can you add a more descriptive title

(Amend)

#8972 - Fixes issue when Dependabot generates a PR commit message that is longer than 65536 chars.
@sachin-sandhu sachin-sandhu changed the title Fixes: https://github.com/dependabot/dependabot-core/issues/8972 Fixes: Fixes issue when Dependabot generates a PR commit message that is longer than 65536 chars. May 14, 2024
@sachin-sandhu sachin-sandhu marked this pull request as draft May 14, 2024 16:52
@OmarTawfik
Copy link

OmarTawfik commented May 15, 2024

According to the error message I got earlier, the maximum length was 16,383 not 65,535. Please see screenshot below.
I wonder if this recently changed?

image

@sachin-sandhu
Copy link
Contributor Author

sachin-sandhu commented May 17, 2024

Closing pull request

@sachin-sandhu sachin-sandhu deleted the ssandhu/8972-merge-failed-commit-message-is-too-long-maximum-is-16383-characters branch May 19, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge failed: Commit message is too long (maximum is 16383 characters)
3 participants