-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge failed: Commit message is too long (maximum is 16383 characters) #8972
Comments
I am unable recreate above problem Step I followed are below
Only error I saw while running check for updates is
But it is not related to this ticket. Could you please let me know the steps to reproduce and let me know why you think this issue is related to dependabot pls FYI @abdulapopoola and @jurre |
Reg: Analyzing on NomicFoundation/slang#930 And this PR is not generated by dependabot, I couldn't find the job related to this PR |
I see in your fork, you are testing the You can possibly try to reproduce the same update commit by running against its parent commit, not the latest But I don't think you necessarily need to reproduce it. You can just check the commit message locally if you want. This update commit message has 40841 characters, because there were many dependencies updated. But the maximum allowed by GitHub to merge a PR is 16383 characters, so it can never be merged, resulting the error I posted above. To unblock ourselves, I had to check out the PR locally, edit the commit message to truncate it, then force push and try to merge again. I believe dependeabot should enforce the same length on the commits it creates, to match GitHub restrictions, truncating the message if it was too long. As for the other |
Hi @OmarTawfik , I went through the dependabot generated PR commit message (9feb42d8) and found the length to be 65849 ( git show -s --format=%B 9feb42d8 | wc -c ) . GitHub has a max limit of 65536 chars for a commit message. Hence the PR generated an issue. We are pushing a fix that should fix this issue. |
Closing the issue as fix is deployed. |
Is there an existing issue for this?
Package ecosystem
cargo
Package manager version
No response
Language version
No response
Manifest location and content before the Dependabot update
/Cargo.toml
dependabot.yml content
https://github.com/NomicFoundation/slang/blob/main/.github/dependabot.yml
Updated dependency
NomicFoundation/slang#778
What you expected to see, versus what you actually saw
Expected
A valid commit that can be merged.
Actual
Maybe for such extreme cases, we can just truncate the message?
Native package manager behavior
No response
Images of the diff or a link to the PR, issue, or logs
NomicFoundation/slang@7cf7241
Smallest manifest that reproduces the issue
No response
The text was updated successfully, but these errors were encountered: