fix(biome): use temp file instead of stdin #4775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Having a hard time figuring out why the Github actions seem to be stuck without any visible way to retry them.... maybe @w0rp can help here. |
|
@hsanson I think an approval might kick off the tests
Could be that it's stale or something though? I'll try pulling in the latest and updating my branch Edit: I get a slightly different message on mobile that maybe makes it more clear that's what's going on:
The other message I saw was unclear if approval was needed for the workflow or to actually merge. Still not clear if the PR itself needs approval or if there's some other way to approve just the workflow. |
biome handles utf8 characters differently between files and stdin, and in some cases can replace emojis with ascii characters when using stdin refs: biomejs/biome#2604
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
biome handles utf8 characters differently between files and stdin, and in some cases can replace emojis with ascii characters when using stdin
refs: biomejs/biome#2604
This is pretty small but I made sure to update the relevant test. Again, it will have minor conflicts with #4774, #4763, and #4773, but I wanted to keep the fixes focused.
Vader tests and linters are passing locally.
I have another change pending to add biome support for json and jsonc and clean up the options, but it sort of depends on some of these other PRs so I'll wait until these are resolved.