Fix #2263 - detailed Flow errors should show the original message

dense-analysis · Feb 1, 2019 · 0ed3fbc · 0ed3fbc
1 parent b315667
commit 0ed3fbc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/ale_linters/javascript/flow.vim b/ale_linters/javascript/flow.vim
@@ -155,7 +155,8 @@ function! ale_linters#javascript#flow#Handle(buffer, lines) abort
  \}
 
  if has_key(l:error, 'extra')
- let l:errorToAdd.detail = s:GetDetails(l:error)
+ let l:errorToAdd.detail = l:errorToAdd.text
+ \  . "\n" . s:GetDetails(l:error)
  endif
 
  call add(l:output, l:errorToAdd)

diff --git a/test/handler/test_flow_handler.vader b/test/handler/test_flow_handler.vader
@@ -499,7 +499,8 @@ Execute(The flow handler should handle extra errors):
  \ 'col': 35,
  \ 'type': 'E',
  \ 'text': 'props of React element `New`: This type is incompatible with object type',
- \ 'detail': 'Property `setVector` is incompatible: number This type is incompatible with function type ',
+ \ 'detail': 'props of React element `New`: This type is incompatible with object type'
+ \ . "\nProperty `setVector` is incompatible: number This type is incompatible with function type ",
  \ }
  \]