Shorthand for IS_BUILD_MODE #2268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deer
suggested changes
Jan 26, 2024
There was a problem hiding this comment.
My standard comment: tests?
Although you could probably get away in this case without writing anything new if you just refactor the one place in the codebase that uses this line to use your new const:
Line 41 in 34c875c
This is executed in the tests, so if it works here, I'd say it's covered.
|
This change has been put in place. Thanks for the thoughts. |
deer
approved these changes
Jan 28, 2024
|
Just updated the branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick shorthand for IS_BUILD_MODE (Deno.args.includes("build")), should help simplify code that needs to not run during ahead of time builds. Will address #2240 .