Skip to content

Commit

Permalink
fix(jsr): panic when importing jsr package with deps via https (#23728)
Browse files Browse the repository at this point in the history
Closes #23644
  • Loading branch information
dsherret committed May 7, 2024
1 parent 25fcfe5 commit 5379bb0
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 17 deletions.
4 changes: 2 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cli/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ deno_config = "=0.16.3"
deno_core = { workspace = true, features = ["include_js_files_for_snapshotting"] }
deno_doc = { version = "=0.129.0", features = ["html", "syntect"] }
deno_emit = "=0.40.2"
deno_graph = { version = "=0.74.4", features = ["tokio_executor"] }
deno_graph = { version = "=0.74.5", features = ["tokio_executor"] }
deno_lint = { version = "=0.58.4", features = ["docs"] }
deno_lockfile.workspace = true
deno_npm = "=0.18.0"
Expand Down
4 changes: 2 additions & 2 deletions tests/specs/jsr/import_jsr_via_https/main.check.out
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
error: Failed resolving types. Importing JSR packages via HTTPS specifiers for type checking is not supported for performance reasons. If you would like types, import via a `jsr:` specifier instead or else use a non-statically analyzable dynamic import.
Importing: http://127.0.0.1:4250/@denotest/add/1.0.0/mod.ts
at file:///[WILDLINE]/import_jsr_via_https/main.ts:1:21
Importing: http://127.0.0.1:4250/@denotest/deps/1.0.0/mod.ts
at file:///[WILDLINE]/import_jsr_via_https/main.ts:1:18
13 changes: 6 additions & 7 deletions tests/specs/jsr/import_jsr_via_https/main.info.out
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
local: [WILDLINE]
emit: [WILDLINE]
type: TypeScript
dependencies: [WILDLINE]
size: [WILDLINE]
[WILDCARD]

file:///[WILDLINE]/main.ts ([WILDLINE])
├── http://127.0.0.1:4250/@denotest/add/1.0.0/mod.ts ([WILDLINE])
├─┬ http://127.0.0.1:4250/@denotest/deps/1.0.0/mod.ts ([WILDLINE])
│ ├── http://127.0.0.1:4250/@denotest/module-graph/1.4.0/other.ts ([WILDLINE])
│ └─┬ http://127.0.0.1:4250/@denotest/no-module-graph/0.1.1/mod.ts ([WILDLINE])
│ └── http://127.0.0.1:4250/@denotest/no-module-graph/0.1.1/TestClass.ts ([WILDLINE])
└── Importing JSR packages via HTTPS specifiers for type checking is not supported for performance reasons. If you would like types, import via a `jsr:` specifier instead or else use a non-statically analyzable dynamic import.
Importing: http://127.0.0.1:4250/@denotest/add/1.0.0/mod.ts (resolve error)
Importing: http://127.0.0.1:4250/@denotest/deps/1.0.0/mod.ts (resolve error)
13 changes: 10 additions & 3 deletions tests/specs/jsr/import_jsr_via_https/main.out
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
Download http://127.0.0.1:4250/@denotest/add/1.0.0_meta.json
Download http://127.0.0.1:4250/@denotest/add/1.0.0/mod.ts
3
Download http://127.0.0.1:4250/@denotest/deps/1.0.0_meta.json
Download http://127.0.0.1:4250/@denotest/deps/1.0.0/mod.ts
Download http://127.0.0.1:4250/@denotest/module-graph/meta.json
Download http://127.0.0.1:4250/@denotest/no-module-graph/meta.json
Download http://127.0.0.1:4250/@denotest/module-graph/1.4.0_meta.json
Download http://127.0.0.1:4250/@denotest/no-module-graph/0.1.1_meta.json
Download http://127.0.0.1:4250/@denotest/no-module-graph/0.1.1/mod.ts
Download http://127.0.0.1:4250/@denotest/no-module-graph/0.1.1/TestClass.ts
Download http://127.0.0.1:4250/@denotest/module-graph/1.4.0/other.ts
0.1.1
4 changes: 2 additions & 2 deletions tests/specs/jsr/import_jsr_via_https/main.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import { add } from "http://127.0.0.1:4250/@denotest/add/1.0.0/mod.ts";
import deps from "http://127.0.0.1:4250/@denotest/deps/1.0.0/mod.ts";

console.log(add(1, 2));
console.log(deps.version);

0 comments on commit 5379bb0

Please sign in to comment.