-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(jsr): panic when importing jsr package with deps via https (#23728)
Closes #23644
- Loading branch information
Showing
6 changed files
with
23 additions
and
17 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
error: Failed resolving types. Importing JSR packages via HTTPS specifiers for type checking is not supported for performance reasons. If you would like types, import via a `jsr:` specifier instead or else use a non-statically analyzable dynamic import. | ||
Importing: http://127.0.0.1:4250/@denotest/add/1.0.0/mod.ts | ||
at file:///[WILDLINE]/import_jsr_via_https/main.ts:1:21 | ||
Importing: http://127.0.0.1:4250/@denotest/deps/1.0.0/mod.ts | ||
at file:///[WILDLINE]/import_jsr_via_https/main.ts:1:18 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,9 @@ | ||
local: [WILDLINE] | ||
emit: [WILDLINE] | ||
type: TypeScript | ||
dependencies: [WILDLINE] | ||
size: [WILDLINE] | ||
[WILDCARD] | ||
|
||
file:///[WILDLINE]/main.ts ([WILDLINE]) | ||
├── http://127.0.0.1:4250/@denotest/add/1.0.0/mod.ts ([WILDLINE]) | ||
├─┬ http://127.0.0.1:4250/@denotest/deps/1.0.0/mod.ts ([WILDLINE]) | ||
│ ├── http://127.0.0.1:4250/@denotest/module-graph/1.4.0/other.ts ([WILDLINE]) | ||
│ └─┬ http://127.0.0.1:4250/@denotest/no-module-graph/0.1.1/mod.ts ([WILDLINE]) | ||
│ └── http://127.0.0.1:4250/@denotest/no-module-graph/0.1.1/TestClass.ts ([WILDLINE]) | ||
└── Importing JSR packages via HTTPS specifiers for type checking is not supported for performance reasons. If you would like types, import via a `jsr:` specifier instead or else use a non-statically analyzable dynamic import. | ||
Importing: http://127.0.0.1:4250/@denotest/add/1.0.0/mod.ts (resolve error) | ||
Importing: http://127.0.0.1:4250/@denotest/deps/1.0.0/mod.ts (resolve error) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,10 @@ | ||
Download http://127.0.0.1:4250/@denotest/add/1.0.0_meta.json | ||
Download http://127.0.0.1:4250/@denotest/add/1.0.0/mod.ts | ||
3 | ||
Download http://127.0.0.1:4250/@denotest/deps/1.0.0_meta.json | ||
Download http://127.0.0.1:4250/@denotest/deps/1.0.0/mod.ts | ||
Download http://127.0.0.1:4250/@denotest/module-graph/meta.json | ||
Download http://127.0.0.1:4250/@denotest/no-module-graph/meta.json | ||
Download http://127.0.0.1:4250/@denotest/module-graph/1.4.0_meta.json | ||
Download http://127.0.0.1:4250/@denotest/no-module-graph/0.1.1_meta.json | ||
Download http://127.0.0.1:4250/@denotest/no-module-graph/0.1.1/mod.ts | ||
Download http://127.0.0.1:4250/@denotest/no-module-graph/0.1.1/TestClass.ts | ||
Download http://127.0.0.1:4250/@denotest/module-graph/1.4.0/other.ts | ||
0.1.1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
import { add } from "http://127.0.0.1:4250/@denotest/add/1.0.0/mod.ts"; | ||
import deps from "http://127.0.0.1:4250/@denotest/deps/1.0.0/mod.ts"; | ||
|
||
console.log(add(1, 2)); | ||
console.log(deps.version); |