Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Proof of concept: Yarn 3 Upgrade #3594

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hydrosquall
Copy link
Contributor

@hydrosquall hydrosquall commented Sep 28, 2022

WIP

  • This doesn't adhere to commit or feature branch dev style yet - just wanted to make this branch available as a reference for testing.

Motivation

  • Bringing the benefits of Yarn's most recent developer experience updates (v2, v3) to Dendron

Changes

  • Followed the migration guide
  • Migrated two NPM scripts since one of the pre-commit hooks was failing to execute.

Commit

  • make sure your branch names adhere to our branch style
  • make sure the commit message follows Dendron's commit style
  • if this pull request is addressing an existing issue, make sure to link this PR to the issue that it is resolving.

Code

  • code should follow Code Conventions
  • sticking to existing conventions instead of creating new ones

Tests

Docs

  • if your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR (NOTE: submit the PR against the dev branch of the dendron-site repo)

  • does this change introduce a new or better way of doing things that others need to be aware of? if so, an async should be created and a process added in Development or Packages

@CLAassistant
Copy link

CLAassistant commented Sep 28, 2022

CLA assistant check
All committers have signed the CLA.

"stash:unstaged": "git stash save -k 'pre-linting-stash'",
"stash:pop": "git stash && git stash pop stash@{1} && git read-tree stash && git stash drop",
"stash:unstaged": "./scripts/stash-unstaged.sh",
"stash:pop": "./scripts/stash-pop.sh",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was failing before, I think it's because Yarn uses its own shell parser to run these scripts, and wasn't handling the {} characters properly. Hoisted these scripts out to their own files to workaround it.

yarnpkg/berry#2670

@hydrosquall hydrosquall changed the title [TEST] Proof of concept: Yarn 3 Update [TEST] Proof of concept: Yarn 3 Upgrade Sep 28, 2022
@hydrosquall hydrosquall force-pushed the cameron.yick/test-yarn-3-upgrade branch from 06cda9c to c78600f Compare September 28, 2022 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants