Fixes to the backup import #5086
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
force-pushed
the
iequidoo/import_backup
branch
2 times, most recently
from
f3effee
to
71f8626
Compare
iequidoo
commented
Dec 6, 2023
flub
approved these changes
Dec 9, 2023
iequidoo
force-pushed
the
iequidoo/import_backup
branch
from
71f8626
to
6364bde
Compare
This way we can't get an account with missing blobs if there's not enough disk space. Also delete already unpacked files if all files weren't unpacked successfully. Still, there are some minor problems remaining: - If a db wasn't imported successfully, unpacked blobs aren't deleted because we don't know at which step the import failed and whether the db will reference the blobs after a restart. - If `delete_and_reset_all_device_msgs()` fails, the whole `import_backup()` fails also, but after a restart delete_and_reset_all_device_msgs() isn't retried. Probably errors from it should be ignored at all, but let's postpone changing this for now.
Otherwise we continue to work with an incompletely imported db... but only until restart -- after that all changes to the db are lost.
…ice_msgs() They are not a good reason to fail the whole import. Anyway `delete_and_reset_all_device_msgs()` isn't retried after restarting the program.
iequidoo
force-pushed
the
iequidoo/import_backup
branch
from
6364bde
to
5fe48a1
Compare
link2xt
force-pushed
the
main
branch
2 times, most recently
from
1abb12e
to
2af9ff1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.
Also need to think how to add at least some tests for this.