Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mdm_ips, add taint msg and check SDC existing name #195

Merged
merged 6 commits into from
Jun 18, 2024

Conversation

rounak-adhikary
Copy link
Collaborator

Tests

root@lglap049:~/terraform-provider-powerflex# go test ./powerflex/provider/ -v -timeout 8h -run TestAccSDCHostResource
=== RUN   TestAccSDCHostResourceUbuntu
--- PASS: TestAccSDCHostResourceUbuntu (21.61s)
=== RUN   TestAccSDCHostResourceEsxiNeg
--- PASS: TestAccSDCHostResourceEsxiNeg (0.32s)
=== RUN   TestAccSDCHostResourceEsxi
--- PASS: TestAccSDCHostResourceEsxi (118.78s)
=== RUN   TestAccSDCHostResourceNegative
--- PASS: TestAccSDCHostResourceNegative (31.55s)
=== RUN   TestAccSDCHostResourcePositive
    sdc_host_resource_win_test.go:58: Skipping this test case for real environment
--- SKIP: TestAccSDCHostResourcePositive (0.00s)
=== RUN   TestAccSDCHostResourceRPMPositive
    sdc_host_resource_win_test.go:83: Skipping this test case for real environment
--- SKIP: TestAccSDCHostResourceRPMPositive (0.00s)
PASS
ok      terraform-provider-powerflex/powerflex/provider 172.293s
root@lglap049:~/terraform-provider-powerflex#

@terraform-providers-svc
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Collaborator

@Krunal-Thakkar Krunal-Thakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnikaAgiwal2711
Copy link
Collaborator

run e2e test

@rounak-adhikary rounak-adhikary merged commit 9a0036e into main Jun 18, 2024
7 checks passed
@rounak-adhikary rounak-adhikary deleted the sdc_host_nuance branch June 18, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants