Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc enhancements #194

Merged
merged 11 commits into from
Jun 20, 2024
Merged

doc enhancements #194

merged 11 commits into from
Jun 20, 2024

Conversation

shenda1
Copy link
Collaborator

@shenda1 shenda1 commented Jun 17, 2024

Description

PR is raised to address doc enhancements.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@shenda1
doc enhancements
a4d50f6 
Signed-off-by: Shendge <[email protected]>
gokul-srivathsan
gokul-srivathsan previously approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@gokul-srivathsan gokul-srivathsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

gokul-srivathsan
gokul-srivathsan approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@gokul-srivathsan gokul-srivathsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenda1 shenda1 merged commit acd7860 into main Jun 20, 2024
6 checks passed
@Krunal-Thakkar Krunal-Thakkar deleted the 1.5_doc_enhancements branch June 20, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Krunal-Thakkar Krunal-Thakkar Krunal-Thakkar approved these changes

@gokul-srivathsan gokul-srivathsan gokul-srivathsan approved these changes

@AnikaAgiwal2711 AnikaAgiwal2711 Awaiting requested review from AnikaAgiwal2711 AnikaAgiwal2711 is a code owner

@Krishnan-Priyanshu Krishnan-Priyanshu Awaiting requested review from Krishnan-Priyanshu Krishnan-Priyanshu is a code owner

@rounak-adhikary rounak-adhikary Awaiting requested review from rounak-adhikary rounak-adhikary is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@shenda1 @rounak-adhikary @Krunal-Thakkar @gokul-srivathsan