fixed system resource bugs (#192)

Signed-off-by: Shendge <[email protected]>

docs/resources/system.md

@@ -113,4 +113,7 @@ Import is supported using the following syntax:
 
 # import system
 terraform import powerflex_system.test ""
+
+# Another way to import system using system ID
+terraform import powerflex_system.test "system_id"
 ```

examples/resources/powerflex_system/import.sh

@@ -12,4 +12,7 @@
 # */
 
 # import system
-terraform import powerflex_system.test ""
+terraform import powerflex_system.test ""
+
+# Another way to import system using system ID
+terraform import powerflex_system.test "system_id"

powerflex/provider/system_resource.go

@@ -459,6 +459,24 @@ func (r *systemResource) Delete(ctx context.Context, req resource.DeleteRequest,
 
 func (r *systemResource) ImportState(ctx context.Context, req resource.ImportStateRequest, resp *resource.ImportStateResponse) {
  // Retrieve import ID and save to id attribute
+ if req.ID != "" {
+ systems, err := r.client.GetInstance("")
+ if err != nil {
+ resp.Diagnostics.AddError(
+ "Error in getting system instance on the PowerFlex cluster",
+ "Could not get system instance, unexpected err: "+err.Error(),
+ )
+ return
+ }
+
+ if req.ID != systems[0].ID {
+ resp.Diagnostics.AddError(
+ "Error in importing system",
+ "Could not import system with ID: "+req.ID,
+ )
+ return
+ }
+ }
  resource.ImportStatePassthroughID(ctx, path.Root("id"), req, resp)
 }
 
@@ -500,6 +518,18 @@ func (r *systemResource) PopulateSDCDetails(ctx context.Context, plan *models.Sy
  SdcGuids = append(SdcGuids, sdc.Sdc.SdcGUID)
  }
  plan.SdcGuids, _ = types.ListValueFrom(ctx, types.StringType, SdcGuids)
+ } else {
+ diags.Append(plan.SdcGuids.ElementsAs(ctx, &SdcGuids, true)...)
+ for _, guid := range SdcGuids {
+ _, err := r.system.FindSdc("SdcGUID", guid)
+ if err != nil {
+ diags.AddError(
+ "Error getting SDC with GUID: ",
+ "unexpected error: "+err.Error(),
+ )
+ return
+ }
+ }
  }
  return
 }

powerflex/provider/system_resource_test.go

@@ -37,6 +37,10 @@ func TestAccSystemResource(t *testing.T) {
  Config: ProviderConfigForTesting + SystemResourceConfig6,
  ExpectError: regexp.MustCompile(".*Error getting SDC with ID.*"),
  },
+ {
+ Config: ProviderConfigForTesting + SystemResourceConfig9,
+ ExpectError: regexp.MustCompile(".*Error getting SDC with GUID.*"),
+ },
  {
  Config: ProviderConfigForTesting + SystemResourceConfig1,
  Check: resource.ComposeAggregateTestCheckFunc(
@@ -190,3 +194,9 @@ resource "powerflex_system" "test" {
  sdc_ids = [data.powerflex_sdc.selected.id]
 }
 `
+var SystemResourceConfig9 = `
+resource "powerflex_system" "test" {
+ restricted_mode = "Guid"
+ sdc_guids = ["invalid_guid"]
+}
+`