Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.3.0: Sonar Fix #667

Merged
merged 11 commits into from
May 23, 2024
Merged

Conversation

ABHISHEK-SINHA10
Copy link
Collaborator

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • Test Pull Request
COMPONENT NAME
OUTPUT

ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.39%. Comparing base (bef2ec5) to head (aba8f8b).
Report is 15 commits behind head on collections.

Additional details and impacted files
@@               Coverage Diff               @@
##           collections     #667      +/-   ##
===============================================
- Coverage        93.48%   91.39%   -2.10%     
===============================================
  Files              201      203       +2     
  Lines            34500    34707     +207     
  Branches          5251     5297      +46     
===============================================
- Hits             32253    31721     -532     
- Misses            1345     1355      +10     
- Partials           902     1631     +729     
Flag Coverage Δ
units 91.39% <100.00%> (-2.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kritika-Bhateja-03 Kritika-Bhateja-03 merged commit 43e633b into dell:collections May 23, 2024
28 checks passed
@rajshekarp87 rajshekarp87 added the validation/completed Validation is completed label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation/completed Validation is completed
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants