Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove :injections from editor tests #7769

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Remove :injections from editor tests #7769

wants to merge 1 commit into from

Conversation

matgis
Copy link
Contributor

@matgis matgis commented Jun 29, 2023 •
edited

Technical changes

  • Remove unneeded :injections section from :test profile.
  • Remove unsupported --illegal-access=warn JVM parameter.

@matgis matgis requested a review from vlaaad June 29, 2023 14:22
vlaaad
vlaaad previously approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@vlaaad vlaaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@matgis matgis force-pushed the ed2-remove-test-injections branch from 7b633fa to 726f7ff Compare June 29, 2023 19:02
@matgis matgis changed the title Editor: Fix freeze when running tests locally Remove :injections from editor tests Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlaaad vlaaad vlaaad left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matgis @vlaaad